Beaker from master (which is v0.10.2) with local changes to the safe-app plugin to log info about handles being created and freed. If you are up for doing the same I can publish the modified plugin somewhere for you to use it.
Gabriel, SB 0.10.2 works as advertised, freeing connections on closing a tab so I went back to test again using the fork you made and it doesn’t free the connections on closing the tab, as I reported a while back:
I’m not sure why, but I guess I messed up getting your changes and don’t have the version with your pre-merge fix. I’m not very good with git Here’s what I have for the temporary fork you made:
$ git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working directory clean $ git remote --verbose origin https://github.com/bochaco/safe_browser.git (fetch) origin https://github.com/bochaco/safe_browser.git (push) $ git log commit 4ab8eda09e2e4db808ef4140603e03652040af4c Author: Gabriel Viganotti <firstname.lastname@example.org> Date: Mon Mar 12 08:37:14 2018 -0300 chore/safe-app plugin: Version change to v0.10.1 to upgrade safe-app plugin to v0.5.2 (#256)
Anyway, that’s why I sent you on a wild goose chase. Sorry about that. I have spotted where I’m messing up freeing the handles and will now work on fixing that up.
Thanks again for your help.
Nice, that’s good news then. It seems you made the same mistake that I made with one of your repo’s which was forgetting to switch to the correct branch and just use
master, you should have used the branch
MAID-2602 from my repo which has the following commit on top of the one you have: https://github.com/bochaco/safe_browser/commit/280521200d673c86b94fbd2b2b2fe6e33a9ed1af
so if that makes you feel better, I also made that mistake yesterday with you safenetwork-webapi repo . Anyhow, it’s good we seem to have an explanation for everything now, otherwise it would be doubtful.
On a side note, this is why we are trying to remove the handles from Peruse and just expose safe_app_nodejs API as the Web API so we won’t need to worry about freeing them.
Are you gentlemen okay now with me closing this? Seems to have been ironed out and I can lock it down. Any other issues would justify another post I’d say.